securityReportSummary endpoint should not access the artifact
What does this MR do?
For some time the scannedResources and scannedResourcesCount of the securityReportSummary have been causing timeouts. The problem stems from the need to retrieve scanned resources from build artifacts which is slow and full described in #322349 (closed)
This was initially dealt with by removing the calls to scannedResources and scannedResourcesCount in !54255 (diffs) however, even without requesting scannedResources and scannedResourcesCount the artifacts were still being downloaded.
This MR removes the expensive operation return unless report_exists?(report_type) which implicitly downloaded the artifacts and replaces it a DB query to check if a Pipeline has security_findings. security_findings are generated from the artifact and so this would not exist if the artifact did not.
This MR relates to #330122 (closed)
The corresponding Front End change !61551 (merged)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team