Improves Performance of VulnerabilityReportsComparer when using signatures
requested to merge improve_vuln_tracking-improve_vuln_report_comparison_perf_into_fix into 329436-wrap-security-report-comparison-behind-sig-feat-flag
testing_source_and_reports.zip
What does this MR do?
This MR uses a faster approach to comparing vulnerability findings by their prioritized signatures by precomputing data.
This MR target's @theoretick's branch directly for easier reviewing. !61200 (merged) targets the master branch.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by James Johnson