Skip to content

Resolve "Usage Data name suggestion returns a number"

What does this MR do?

Fix bug on name suggestion generator

Before

# more approvers

Gitlab::Usage::Metrics::NamesSuggestions::Generator.generate('usage_activity_by_stage_monthly.create.approval_project_rules_with_more_approvers_than_required')
=> 129

# less_approvers

Gitlab::Usage::Metrics::NamesSuggestions::Generator.generate('usage_activity_by_stage_monthly.create.approval_project_rules_with_less_approvers_than_required')
=> 129

After


# more approvers 

Gitlab::Usage::Metrics::NamesSuggestions::Generator.generate('usage_activity_by_stage_monthly.create.approval_project_rules_with_more_approvers_than_required')
=> "count_<adjective describing: '(approval_project_rules.rule_type = 0)'>_approval_project_rules_<with>_approval_project_rules_users"


 # less approvers

Gitlab::Usage::Metrics::NamesSuggestions::Generator.generate('usage_activity_by_stage_monthly.create.approval_project_rules_with_less_approvers_than_required')
=> "count_<adjective describing: '(approval_project_rules.rule_type = 0)'>_approval_project_rules_<with>_approval_project_rules_users"

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #330109 (closed)

Edited by Luis Mejia

Merge request reports