Remove unnecessary query from close_issue method [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
The current code executes the following two DB operations when closing an issue:
- sets the
closed_atvalue for the issue to the current time - sets the
closed_by_idvalue for the issue to the current user
This MR is an optimisation which reduces the number of queries from 2 to 1 by combining both of the above updates into a single DB query
What are the relevant issue numbers?
Database
Before
UPDATE "issues" SET "updated_at" = '2021-05-06 03:32:20.104026', "closed_at" = '2021-05-06 03:32:20.088684', "state_id" = 2 WHERE "issues"."id" = 1
UPDATE "issues" SET "updated_at" = '2021-05-06 03:32:20.208281', "closed_by_id" = 1 WHERE "issues"."id" = 1 After
UPDATE "issues" SET "updated_at" = '2021-05-06 03:35:27.745054', "closed_at" = '2021-05-06 03:35:27.733288', "closed_by_id" = 1, "state_id" = 2 WHERE "issues"."id" = 1 Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #4794 (closed)
Edited by Mayra Cabrera