Add offset and limit parameters to names resolver
What does this MR do?
Adds offset
and limit
to the branch names resolver to be used by the frontend. This will allow the frontend to efficiently query branch names in a repository. The first use-case is for the pipeline editor branch dropdown - !59217 (merged).
Related #329652 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Does this MR need a changelog?-
I have included a changelog entry. - N/A I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides - N/A Database guides
- N/A Separation of EE specific content
Merge request reports
Activity
changed milestone to %13.12
added 2 commits
added workflowin review label
mentioned in merge request !59217 (merged)
added backend documentation labels
2 Messages This merge request adds or changes files that require a review from the Database team. This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
app/finders/repositories/branch_names_finder.rb
Documentation review
The following files require a review from a technical writer:
doc/api/graphql/reference/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Alina Mihaila ( @alinamihaila
) (UTC+3, 1 hour ahead of@matteeyah
)Kerri Miller ( @kerrizor
) (UTC-7, 9 hours behind@matteeyah
)database David Sincheol Kim ( @dskim_gitlab
) (UTC+9.5, 7.5 hours ahead of@matteeyah
)Steve Abrams ( @sabrams
) (UTC-6, 8 hours behind@matteeyah
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖@marcel.amirault Can you take a look at the docs changes here?
requested review from @marcel.amirault
- Resolved by Sean McGivern
requested review from @rcobb
requested review from @smcgivern and removed review request for @rcobb
mentioned in issue #321655 (closed)
- Resolved by Matija Čupić
- Resolved by Sean McGivern
- Resolved by Matija Čupić
- Resolved by Matija Čupić
removed review request for @smcgivern
added Technical Writing docsfeature twfinished labels
removed review request for @marcel.amirault
added 2 commits
added 1 commit
- 69df8359 - Move offset and limit params to BranchNamesFinder
added databasereview pending label
added database label
requested review from @smcgivern
added 1 commit
- 33e4d84f - Move offset and limit params to BranchNamesFinder
added 1 commit
- 7ea04c22 - Move offset and limit params to BranchNamesFinder
- Resolved by Sean McGivern
- Resolved by Sean McGivern
- Resolved by Matija Čupić
- Resolved by Matija Čupić
removed review request for @smcgivern
added 1 commit
- e40bf17b - Move offset and limit params to BranchNamesFinder
added 1 commit
- e8c1d3e7 - Move offset and limit params to BranchNamesFinder
enabled an automatic merge when the pipeline for ff89181c succeeds
mentioned in commit 06d92619
mentioned in issue gitlab-com/gl-infra/scalability#1061
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label