Skip to content

Render an Error on the Billing Page When CustomersDot is Unavailable

Jason Goodman requested to merge billing-page-when-customers-down into master

What does this MR do?

Display an error page when CustomersDot is down and the user visits the Billing page.

Previously, this scenario would result in a 500 error from GitLab.

This MR fixes this issue for both the Group and Profile billing pages.

Issue: #320931 (closed)

UX: #320931[Billing_page_error_loading.png]

Screenshots

Group Billing Page When CustomersDot is Available:

This contains no changes and is just here for context.

Screen_Shot_2021-05-05_at_2.29.34_PM

Group Billing Page When CustomersDot is Unavailable:

This is one of the changes in this MR. Previously this page results in an error when CustomersDot is unavailable. See the last picture below.

Screen_Shot_2021-05-05_at_1.38.14_PM

Profile Billing Page When CustomersDot is Available:

This contains no changes and is just here for context.

Screen_Shot_2021-05-05_at_3.32.14_PM

Profile Billing Page When CustomersDot is Unavailable:

This is one of the changes in this MR. Previously this page results in an error when CustomersDot is unavailable. See the last picture below.

Screen_Shot_2021-05-05_at_3.31.38_PM

Billing Page When CustomersDot is Unavailable Prior to this MR:

This is a local screenshot. It would look different in production, but this illustrates the error. This is the behavior fixed by this MR.

Screen_Shot

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jason Goodman

Merge request reports