Skip to content

Expose is_auditor user role via API [RUN AS-IF-FOSS]

Serena Fang requested to merge expose-is-auditor into master

What does this MR do?

#300127 (closed)

Similar to how we expose is_admin when using the user API as an admin, provide is_auditor boolean attribute.

As an admin:

% curl --header "PRIVATE-TOKEN: $TOKEN" "http://172.16.123.1:3000/api/v4/users/103" | json_pp
{
   ...
   ...
   "is_admin" : false,
   "is_auditor" : true,
   ...
   "name" : "audit or",
   ...
   "username" : "auditor",
   ...
}

As a non-admin:

{
  "id": 103,
  "username": "auditor",
  "name": "audit or",
  ...
  ...
  # does NOT have "is_auditor" field
 
}

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Reuben Pereira

Merge request reports