Remove feature flag from upgrade link in profile menu [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Removes feature flag :upgrade_link_in_user_menu_a
Feature flag was added in 13.11, converted from an experiment feature flag :upgrade_link_in_user_menu_a_experiment_percentage
that had previously been running at 100%: !56591 (merged), to be removed after one milestone in 13.12.
- only displays Upgrade link to users on bronze or silver plans.
- does not display to users if their personal namespace or any of their groups are already on the top tier gold plan.
Related to successful experiment cleanup issue: https://gitlab.com/gitlab-org/gitlab/-/issues/300824
Original experiment MR: !29428 (merged)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Jackie Fraser