Skip to content

Adjust how we push experiment data into the client

Jeremy Jackson requested to merge jejacks0n/publish-experiments-natively into master

What does this MR do?

backend

Switches to using the ApplicationExperiment.published_experiment method, which works nicer for running experiments in non-controller/view layers, and gives us more control over when this is rendered, so all partials can be rendered before the data surfaces to the client.

We push this into the client as window.gl.experiments now, so need to switch up the way it's used in the client.

frontend

Utilizes this new gl.experiments object, replacing the window.gon.experiment usage. This also addresses including all relevant experiment contexts in all events now, so cleans up the existing ways this was being handled, and improves on a couple of the helpers and utility methods.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jeremy Jackson

Merge request reports