Skip to content

Application setting for FloC participation (disabled by default)

Lukas 'ai-pi' Eipert requested to merge leipert-floc-opt-out-327904 into master

What does this MR do?

This opts out GitLab from FloC per default. We add an instance setting for administrators if they want to enable FloC for their instanc, under: Admin > Settings > General

Screenshots

Screenshot_2021-05-04_at_16.48.51

Database

Migration Up

== 20210504135823 AddFlocApplicationSettings: migrating =======================
-- add_column(:application_settings, :floc_enabled, :boolean, {:default=>false, :null=>false})
   -> 0.0068s
== 20210504135823 AddFlocApplicationSettings: migrated (0.0069s) ==============

Migration Down

== 20210504135823 AddFlocApplicationSettings: reverting =======================
-- remove_column(:application_settings, :floc_enabled, :boolean, {:default=>false, :null=>false})
   -> 0.0049s
== 20210504135823 AddFlocApplicationSettings: reverted (0.0095s) ==============

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas 'ai-pi' Eipert

Merge request reports