Resolve "Issue due date changes without user input"
What does this MR do?
Resolves #329614 (closed).
This MR makes the due date widget to set an initial date for GlDatePicker through default-date prop rather than value.
Why?
When mounted GlDatePicker watches for value prop, comparing this value to Pikaday's internal date value (which is always null initially). GlDatePicker thus calls setDate method which in turn triggers input event:
// https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/datepicker/datepicker.vue
watch: {
value(val) {
if (!areDatesEqual(val, this.calendar.getDate())) {
this.calendar.setDate(val, true);
}
},This sometimes set off the due date mutation on page load, probably causing the bug reported in the #329614 (closed).
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #329614 (closed)
Edited by euko