Skip to content

Add blocking sign in for users not allowed to use password auth for web

Gosia Ksionek requested to merge protect_sessions_controller into master

What does this MR do?

I noticed that users that are not supposed to be able to log in through password authentication (have allow_password_authentication_for_web? method return false) can log in - in SessionsController it was not checked.

This MR checks during login if user was trying to use username/password couple and if they are allowed to log in like that. If not, they are not being logged in.

Screenshots (strongly suggested)

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Resolves #330497 (closed)

Edited by Gosia Ksionek

Merge request reports