Skip to content

Fixes XSS in shared runner description

Miguel Rincon requested to merge 329493-confidential-issue into master

What does this MR do?

Shared runner descriptions written by administrators may include non-secure HTML. This fix sanitizes the HTML.

Note: This issue is greatly mitigrated as it can only be exploited by users that are already admins. So this fix is pulic and won't be part of the security release process.

Screenshots (strongly suggested)

Input in admin section Secure output (does not allow XSS)
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #329493 (closed)

Edited by Miguel Rincon

Merge request reports