Skip to content

Stop checking codeowner changes on MR refresh for deleted branch

Marc Shaw requested to merge fix_branch_deleted_code_owners_check into master

What does this MR do?

Issue: #329839 (closed)

When we refresh the merge requests, and the branch is deleted, there is an issue when checking for code owner updates

https://sentry.gitlab.net/gitlab/gitlabcom/issues/2591169/?query=transaction%3A%22Sidekiq%2FUpdateMergeRequestsWorker%22

It makes sense that we actually do sync the code owner approval rules since the code owner's have changed because we deleted, but we rely on the target branch to exist later on.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Marc Shaw

Merge request reports