Skip to content

Avoid window functions in MR diff preloader

Adam Hegyi requested to merge mr-diff-preloader-perf-improvement into master

What does this MR do?

This MR slightly alters the MR diff preloader query to avoid window functions. Looks like using window functions + distinct might cause too many rows to be read. This problem came up with a similar preloading attempt: #329621

Note: there is no significant performance difference here. I want to use this preloader as an example for has_one preloading where the association definition contains an ORDER BY clause.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Adam Hegyi

Merge request reports