Skip to content

Refactor in-product-marketing messages

What does this MR do?

This refactors the in-product-marketing emails into separate classes. So far everything was in a helper, by separating it into classes, we:

This MR looks huge, but is mostly moving code around.

How to test the email locally if you're interested to see how it looks like

  1. bin/rails c
  2. NotificationService.new.in_product_marketing(User.first.id, Group.first.id, :create, 0)
  3. Go to http://localhost:3000/rails/letter_opener/

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Thong Kuah

Merge request reports