Skip to content

Update user_popover target prop type to any HTML element

Jiaan Louw requested to merge 329518-allow-any-element-for-userpopover into master

What does this MR do?

This MR updates user_popover.vue to accept any given HTMLElement as the target prop. This resolves the admin/users issue #329518 (closed) using the suggested method from this comment #329518 (comment 564536775).

Testing & Setup

To confirm the changes on admin/users Vue table:

  1. Enable the feature flag echo "Feature.enable(:vue_admin_users)" | rails c
  2. View the Vue table at [GDK_HOST]/admin/users
  3. Checkout default branch and repeat 1 & 2

Screenshots (strongly suggested)

Before After
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #329518 (closed)

Edited by Jiaan Louw

Merge request reports