Skip to content

Reduces page_bundle CSS for TODO list

Takuya Noguchi requested to merge 326918-todo-css into master

What does this MR do?

Reduces page_bundle CSS for TODO list as well as makes performant in rendering.

LOC of app/assets/stylesheets/page_bundles/todos.scss

before after
258 94

app/assets/stylesheets/page_bundles/todos.scss cannot be completely eliminated all at once since highlighting a TODO element in a list is not generalized at https://gitlab.com/gitlab-org/gitlab-ui.

Screenshots (strongly suggested)

Case Before After
Normal https://www.youtube.com/watch?v=28VUrcRlpAs&list=PLHs2tISONwl_Mbd1H4z7UmwWWjAxBp-p- https://www.youtube.com/watch?v=WWSUr0_eWCY
Normal (mobile) skip https://www.youtube.com/watch?v=cZL0P66WAGM
on PC for newbie gitlab-review-326918-tod-xk8kwk.gitlab-review.app_dashboard_todos_iPad_Pro_ gitlab-review-326918-tod-xk8kwk.gitlab-review.app_dashboard_todos_iPad_Pro_
on mobile for newbie gitlab-review-326918-tod-xk8kwk.gitlab-review.app_dashboard_todos_iPhone_X_ gitlab-review-326918-tod-xk8kwk.gitlab-review.app_dashboard_todos_iPhone_X_

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #326918 (closed)

Edited by Takuya Noguchi

Merge request reports