Update lock timeout in ElasticCommitIndexerWorker to 1 day
What does this MR do?
This lock prevents indexing the same project twice in parallel which is a big problem. The lock will clear itself when the job finishes but you need a timeout since the lock lives in Redis and the process may crash before it can clear the lock.
We chose 1 hour originally since we assumed this was enough time to finish indexing any project but we've found from several customer tickets #323856 (closed) that some very large projects are taking longer than an hour to finish indexing. Increasing this to 1 day probably will dramatically reduce the risk of 2 projects indexing at the same time while still providing a reasonable timeout in the rare event the process crashes and can't clean up the lock.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #323856 (closed)