Check duplicate package regex against version as well as name
🏘 Context
Users have the ability to allow or disallow duplicate package uploads in the Maven package registry. When users do not allow duplicates, they can include a regex to match packages that should still allow duplicates.
❓ Problem
The original request for these options was so Maven users could say "I do not want duplicates on any packages unless I am uploading 'Snapshot' packages", which are packages that contain SNAPSHOT in the version value (for example 1.0-SNAPSHOT).
When we match against the regex, we only look at the incoming package name, not the provided version.
🔎 What does this MR do?
- Updates the PackageSettings logic to match the exception duplicate regex value against the package version in addition to the package name.
- Adds test coverage to the maven package type to ensure this functions as expected.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. - [-] I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #321772 (closed)