Skip to content

Refactor DAST Site Profile form

Dheeraj Joshi requested to merge djadmin-fix-nested-auth-forms into master

Related issue - #328376 (closed)

What does this MR do?

  • This MR tries to fix an issue with toggling radio buttons within the DAST Site Profile form. The root cause of the issue is due to discrepancy with how its child component (DastSiteAuthSection) communicates / updates the form data in the parent component DastSiteProfileForm.
  1. DastSiteAuthSection updates the form data on component creation, keeps both component in sync
  2. DastSiteAuthSection updates the parent component with only required data, ie. serialized form fields & form state
  3. DastSiteAuthSection receives isEdit state to distinguish between new form or updating an existing form.

Screenshots (strongly suggested)

before after
bug dast_site_radio_button_issue

How to test this

  1. Enable the feature flag.
echo " Feature.enable(:security_dast_site_profiles_api_option)" | rails c
  1. Navigate to the DAST profile library page in your GDK: /:namespace/:project/-/security/configuration/dast_profiles#site-profiles
  2. Select create new site profile

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Dheeraj Joshi

Merge request reports