Fix Structured Logger
What does this MR do?
When job is delayed, instrumentation logger will not fill instrumentation data for the structure logger, it will crash - https://log.gprd.gitlab.net/goto/48e947ad70e352c3f3c537248630b924 - This will result in not logging the proper failed job status with exception when job is retried (only for delayed)
This MR inserts SidekiqServerMiddleware after InstrumentationLogger, and it prevents StructuredLogger to crash if job['instrumentation'] is empty.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team