Skip to content

Support multi schedule alert

David O'Regan requested to merge 273797-multi-schedules-feedback-note into master

What does this MR do?

A small MVC for #273797 (closed) where we update the schedule create alert text to support the idea of multiple schedules as per: #273797 (comment 556382219)

For the moment we use a placeholder href which links to the Epic until the EP documentation link is available.

Merge Train

Merge You are here
Allow for multiple schedule creation !59829 (merged)
Add tooltip for add schedule button when feature flag is enabled !60162 (merged)
Clear the schedule form between form creation !60417 (merged)
Only request open schedules to improve performance !60441 (merged)
Update schedule create popover text (after EP are implemented) see: #273797 (comment 556382219) 🤘

Screenshots (strongly suggested)

No feature flag feature flag enabled
Screenshot_2021-04-29_at_07.30.13 Screenshot_2021-04-29_at_07.29.04

How to test this?

  1. Enable the feature flag => ❯ echo "Feature.enable(:multiple_oncall_schedules)" | rails c
  2. Ensure you are at least a project maintainer and have a GitLab Premium license running.
  3. Navigate to On-call Schedules for any project => Operations > On-Call Schedules http://localhost:3000/h5bp/html5-boilerplate/-/oncall_schedules
  4. Test CRUD for multiple schedules
  5. Test CRUD for multiple rotations per schedule created
  6. See the rotations are only requested for open schedule cards

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #273797 (closed)

Merge request reports