Skip to content

Fix badge variants in admin/users table

Jiaan Louw requested to merge 326714-fix-minor-admin-users-vue-issues into master

What does this MR do?

This MR fixes the admin/users badges to use one of the accepted GlBadge variants.

image

Testing and setup

  1. Disable the feature flag echo "Feature.disable(:vue_admin_users)" | rails c
  2. View the HAML table with badges at [GDK_HOST]/admin/users
  3. Enable the feature flag echo "Feature.enable(:vue_admin_users)" | rails c
  4. View the Vue table with badges at [GDK_HOST]/admin/users
  5. Checkout default branch and repeat 1-4

Screenshots (strongly suggested)

Feature flag off

Before After
image image

Feature flag on

Before After
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #326714 (closed)

Edited by Jiaan Louw

Merge request reports