Skip to content

[Rails5] Update Gemfile lock-files

blackst0ne requested to merge blackst0ne-update-gemfile-rails5-lock into master

What does this MR do?

The EE port of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19498

The mini_magick dependencies were omitted in Gemfile.rails5.lock file intentionally because the gem should be added both to rails4 and rails5 lock-files.

This MR is an EE counterpart of a community contributor which isn't able to update the lock file for rails4 for now. So I'll update lock-files later in a separate MR.

Are there points in the code the reviewer needs to double check?

No.

Why was this MR needed?

Migration to rails5.

Screenshots (if relevant)

No.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
    • Has been reviewed by a Backend maintainer
    • Has been reviewed by a Database specialist
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Merge request reports