Fixes filter variables bug for pipeline creation
What does this MR do?
Solves a bug that filters out variables that do not contain a value. This bug is located when creating a manual pipeline in the UI where a user provides variables.
Users sometimes rely on variables that have a key but no value and we should respect that. We still retain filtering out empty variables that have no value or key. But now we only filter out variables that do not contain a value.
The BE should treat empty strings in this case as nil.
Where? CI/CD > Pipelines > Run pipeline (click button)
Check: Run a manual pipeline with a variable that has a key but no value, ensure that the variable is still sent.
Related to: #293700 (closed)
Screenshots (strongly suggested)
This screenshot shows that now in our POST we do send variables up that have a key but no value.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team