Skip to content

Change milestone page API calls to startup calls

Coung Ngo requested to merge cngo-milestone-show-startupjs into master

What does this MR do?

This MR changes milestone page REST and GraphQL API calls to startup calls to improve LCP.

GraphQL queries need to be moved to app/graphql/queries with __typenames added and fragments removed for the startup call (see https://docs.gitlab.com/ee/development/fe_guide/graphql.html#making-initial-queries-early-with-graphql-startup-calls)

Related: gitlab-com/www-gitlab-com#11474

Screenshots (strongly suggested)

before after
Screenshot_2021-04-28_at_1.02.32_pm Screenshot_2021-04-28_at_1.28.00_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports