Support wildcard with double asterisks for CI file includes
What does this MR do?
In our previous implementation (!55871 (merged) / !58999 (merged)), we did not consider subfolders. After trying to use this feature for gitlab-org/gitlab (!60052 (merged)), we realized that we need to have a difference between root and subfolders.
For example;
-
.gitlab/ci/*.yml-> Should match all files in the.gitlab/cifolder that end in.yml, but not subfolders. -
.gitlab/ci/**/*.yml-> Should match all files in the.gitlab/cifolder and subfolders that end in.yml.
Related to #25921 (closed)
Screenshots (strongly suggested)
More info is in the previous MR.
Regexp change examples
- For the path
*.md, changed from^.*?\.md$to^([^\/])*?\.md$. - For the path
**.md, changed from^.*?.*?\.md$to^.*?\.md$. - For the path
files/**.md, changed from^files\/.*?.*?\.md$to^files\/.*?\.md$.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because it is behind a feature flag.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec - [] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
-
Security reports checked/validated by a reviewer from the AppSec team
Edited by Furkan Ayhan