Fix warnings in custom generator for metrics definition
What does this MR do?
Related to #326358 (closed).
This removes require_relative in RedisHLLGenerator that loaded UsageMetricDefinitionGenerator again after Rails autoloads the class in certain situations (e.g. while running RSpec), causing numerous already defined constant warnings.
Removing require_relative by itself causes the generator to break, throwing uninitialized constant Gitlab::UsageMetricDefinitionGenerator, because Gitlab::UsageMetricDefinitionGenerator is not autoloaded when the other generator is invoked by rails g gitlab:usage_metric_definition:redis_hll.
To fix this, lib/generators is now added to autoload paths.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because it's a developer-facing change.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team