Skip to content

When DELETING a user, warn Admin user is part of an on-call schedule

What does this MR do?

Adds a message to the confirmation modal that the user is part of the Oncall-schedule on deleting him/her

🇺🇦 you should have the feature flag enabled to see this message

 Feature.enable(:vue_admin_users)

Also, you should have at least GitLab Premium license and admin access

👀 To check

  1. Navigate to Operations/On-call schedules or a direct link is your_project/-/oncall_schedules e.g. http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/oncall_schedules
  2. Create a schedule https://docs.gitlab.com/ee/operations/incident_management/oncall_schedules.html#on-call-schedule-management

2021-04-12_16.06.43

  1. After you'd be able to create schedule rotations

  2. Add some user to the rotation 2021-04-12_16.06.59

  3. Try deleting the user => got to Admin area/Users(http://127.0.0.1:3000/admin/users) => In the users' table in the context menu try deleting the user. You should see the message that user is a part of oncall-schedule in the confirmation modal.

Screen_Shot_2021-04-26_at_19.35.14

Screenshots (strongly suggested)

Screen_Shot_2021-04-27_at_15.42.32

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #323629 (closed)

Edited by Olena Horal-Koretska

Merge request reports