Skip to content

Update button variants to btn-confirm on MR page

What does this MR do?

Makes buttons the same color to follow new GitLab UI guidelines by using btn-confirm.

Screenshots (strongly suggested)

Section Before After Changes
Design management (xs) Design_management_xs_-_before Design_management_xs_-_after Update button variant and alignment, fix margin to align buttons
Design management Design_management_md_-_before Design_management_md_-_after Update button variant and alignment
MR review - Start a review (xs) MR_review_-Start_a_review_xs-_before MR_review_-Start_a_review_xs-_after Reduce bottom margin from 10px to 8px
MR review - Start a review (md) MR_review_-Start_a_review_md-_before MR_review_-Start_a_review_md-_after Fix bottom button margin when buttons break into 2 lines
MR review - Start a review MR_review_-Start_a_review_lg-_before MR_review_-Start_a_review_lg-_after Flex align buttons to reduce margin to 8px
MR review - Review pending MR_review_-Review_pending-_before MR_review_-Review_pending-_after Update button / badge variant

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Justin Ho Tuan Duong

Merge request reports