Skip to content

Allow aliases when parsing Redis configuration

Heinrich Lee Yu requested to merge allow-aliases-for-redis-yml into master

What does this MR do?

!58042 (merged) changed YAML.load to YAML.safe_load.

This MR adds the option to allow aliases when parsing the Redis config files.

Some configs (like those from GCK) use aliases and were broken by the above change. Rails allows aliases in config files like database.yml so we should also allow them here.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński

Merge request reports