Draft: Fix GraphQL keyset pagination ordering of preloaded items
What does this MR do?
If the query is preloaded, the check was returning true and items
retrieved using take, however this did not use the ordering
when the list of items was not an array (actually "loaded" in memory)
See !60189 (comment 559809148) for an example where this resulted in a difference in the generated fixtures with the addition of preloading.
I'm not 100% sure this is an "actual" ~bug (i.e. should we worry about ending up with primary keys in a different order in general) vs the release_links fixture generation test being wrong (generating them with the IDs in the wrong order)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team