Do not expose artifacts on pipeline index
Ref: #324003 (closed)
What does this MR do?
This MR does 2 things:
- Stop exposing
artifacts
data on the pipeline index page - Expose
has_downloadable_artifacts
to determine when we need to display ourdownload button
Why are we doing this?
Part of the ~performance improvement we are doing on the index pipeline page, we decided to load all artifacts for a given pipeline once a user click on the download button as you can see below
Following up !60058 (merged) where we added a new downloadable_artifacts.json
endpoint and !60058 (merged) which uses it to build up new frontend logic.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry.
-
- [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Orefice