Skip to content

Do not expose artifacts on pipeline index

Max Orefice requested to merge mo-dont-expose-artifacts-on-pipeline-index into master

Ref: #324003 (closed)

What does this MR do?

This MR does 2 things:

  • Stop exposing artifacts data on the pipeline index page
  • Expose has_downloadable_artifacts to determine when we need to display our download button

Why are we doing this?

Part of the ~performance improvement we are doing on the index pipeline page, we decided to load all artifacts for a given pipeline once a user click on the download button as you can see below 👇

Following up !60058 (merged) where we added a new downloadable_artifacts.json endpoint and !60058 (merged) which uses it to build up new frontend logic.

Screenshots (strongly suggested)

Lazily_load_pipeline_artifact_in_project_pipelines_index_page___324003____Issues___GitLab.org___GitLab___GitLab_2021-04-20_16-34-46

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Orefice

Merge request reports