Skip to content

Drop Jira proxy setting columns

Arturo Herrero requested to merge 325938-drop-jira-proxy-setting-columns into master

What does this MR do?

We no longer need the Jira proxy settings columns in jira_tracker_data table as we are using the proxy settings via environment variables. https://docs.gitlab.com/omnibus/settings/environment-variables.html#setting-custom-environment-variables.

This reverts !52119 (merged).

We previously ignored the columns during %13.11 with !57260 (merged).

Migration

rails db:migrate 

$ rails db:migrate
== 20210423124223 RemoveProxySettingsToJiraTrackerData: migrating =============
-- remove_column(:jira_tracker_data, :encrypted_proxy_address, :text)
   -> 0.0038s
-- remove_column(:jira_tracker_data, :encrypted_proxy_address_iv, :text)
   -> 0.0009s
-- remove_column(:jira_tracker_data, :encrypted_proxy_port, :text)
   -> 0.0009s
-- remove_column(:jira_tracker_data, :encrypted_proxy_port_iv, :text)
   -> 0.0009s
-- remove_column(:jira_tracker_data, :encrypted_proxy_username, :text)
   -> 0.0010s
-- remove_column(:jira_tracker_data, :encrypted_proxy_username_iv, :text)
   -> 0.0022s
-- remove_column(:jira_tracker_data, :encrypted_proxy_password, :text)
   -> 0.0009s
-- remove_column(:jira_tracker_data, :encrypted_proxy_password_iv, :text)
   -> 0.0009s
== 20210423124223 RemoveProxySettingsToJiraTrackerData: migrated (0.0118s) ====

rails db:migrate:down VERSION=20210423124223 

$ rails db:migrate:down VERSION=20210423124223
== 20210423124223 RemoveProxySettingsToJiraTrackerData: reverting =============
-- add_column(:jira_tracker_data, :encrypted_proxy_password_iv, :text)
   -> 0.0033s
-- add_column(:jira_tracker_data, :encrypted_proxy_password, :text)
   -> 0.0009s
-- add_column(:jira_tracker_data, :encrypted_proxy_username_iv, :text)
   -> 0.0008s
-- add_column(:jira_tracker_data, :encrypted_proxy_username, :text)
   -> 0.0009s
-- add_column(:jira_tracker_data, :encrypted_proxy_port_iv, :text)
   -> 0.0009s
-- add_column(:jira_tracker_data, :encrypted_proxy_port, :text)
   -> 0.0009s
-- add_column(:jira_tracker_data, :encrypted_proxy_address_iv, :text)
   -> 0.0010s
-- add_column(:jira_tracker_data, :encrypted_proxy_address, :text)
   -> 0.0010s
== 20210423124223 RemoveProxySettingsToJiraTrackerData: reverted (0.0156s) ====

Related to #325938 (closed)

Edited by Arturo Herrero

Merge request reports