Skip to content

Follow-up: Update the nMembers translation string in the approval modal

What does this MR do?

This MR improves the translation accuracy of the approval modal warning text by removing the unnecessary separation of the translation strings

Screenshots (strongly suggested)

(No visual changes)

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

  1. Visit approval rules in Projects > General settings > MR approvals or MR > Edit > Approvals
  2. Click the delete icon and confirm the text is shown correctly for single and multiple approvers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #325797 (closed)

Edited by Robert Hunt

Merge request reports