New service to add spent time to MRs
What does this MR do?
This MR adds a specialized service to handle the add_spent_time action for MergeRequests.
This service builds on top of the framework introduced in !58836 (merged) so we can pass the :use_specialized_service to only add the time spent to the merge request without having to update/check everything in it (current approach of the MergeRequests::UpdateService).
What does this new service do?
- Adds a new timelog to the MR based on the duration passed (this uses
TimeTrackable#spend_time) - Creates a system note with the detail of the time added/substracted. Ex:
added 3h of time spent - Tracks the usage data counter related to the spend time action (this happens in MergeRequests::UpdateService#handle_changes)
- Executes the merge request hooks (MergeRequests::BaseService#execute_hooks)
Related issue
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Amparo Luna