Update snowplow to 2.17.3 [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Updates (both??!) snowplow javascript files to the latest 2.* version.
I'm going to loop in product intelligence because this is for a bug fix, but it seems like there is currently no strategy for keeping this up to date (as there's a 3.0.3 release as well).
Required for !60036 (comment 558254910)
There is a flaw where sp.js calls .filter on an HTMLCollection (which is undefined). I couldn't find any matching issues on github, so can't link to anything -- but the deficiency has been resolved in 2.17.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because it doesn't seem like we do for dependency updates.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
I guess it could break some tracking code, but I'm not sure if this is covered well -- on the customers application I setup a proper proxy to ensure that the ajax calls were going through correctly, but there seems to be no concepts like that in the gitlab. So I guess we update it and find out. I've confirmed events appear to be tracked correctly though.