Skip to content

Fetch runner type in runner details using graphql

Miguel Rincon requested to merge mrincon/runner-badge-vue into master

What does this MR do?

Depends on !59763 (merged), part of #329659 (closed)

This change adds an simple GraphQL query to the runner details page to load the runner type asynchronously. It creates the scaffolding by introducing Apollo to this Vue entry point.

  • Feature.enable(:runner_graphql_query) Enables the new GraphQL API
  • Feature.enable(:runner_detailed_view_vue_ui) Enables the Vue UI instead of HAML

Screenshots (strongly suggested)

No UX changes when compared with HAML version, the frontend swapped the implementation of this component:

Visit a runner from the admin page, (e.g. http://gdk.test:3000/admin/runners/9)

Screen_Shot_2021-04-22_at_5.17.26_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon

Merge request reports