Skip to content

Migrate merge request approval settings to vue

Lukas Eipert requested to merge 2452-migrate-approval-settings-to-vue-ee into master

What does this MR do?

Move the merge request approval settings from a Settings > Repository > Merge request settings sub entry to a top level Settings > Repository > Merge request approvals entry. The code is also converted to vue.

Screenshots (if relevant)

approval-settings

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
    • Has been reviewed by a Backend maintainer
    • Has been reviewed by a Database specialist
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

#6346 (closed)

Edited by Coung Ngo

Merge request reports