Skip to content

Fix potential crash in show-commit

Matthias Käppler requested to merge mk-fix-env-lookup-crash into master

What does this MR do?

In development mode when lazy loading classes, this caused Rails to look up Environments on Projects, where it is not defined, causing a crash:

NameError at /gpt/large_projects/gitlabhq1/-/commit/871d01c193bbc52802294cbf7e32234e09d3a199
uninitialized constant Projects::Environments::EnvironmentsByDeploymentsFinder

Explicitly forcing a top-level lookup fixes this. I am unsure how to add test coverage for this.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Matthias Käppler

Merge request reports