Skip to content

Use injection over prop injection

Savas Vedova requested to merge 328232-use-context-instead-of-props into master

What does this MR do?

This is a simple follow up from this discussion. Since groupFullPath and projectFullPath are both injected we moved the logic to compute the fullPath for the vulnerability_count_list component into the component itself. Previously it was in the parent component.

Screenshots (strongly suggested)

There are no visual changes.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #328232 (closed)

Merge request reports