Remove Markdown-it from Content Editor build
What does this MR do?
The Content Editor component uses the prosemirror-markdown
library to serialize ProseMirror documents as Markdown strings. In turn, prosemirror-markdown
uses markdown-it
to deserialize a Markdown strings into ProseMirror documents. We don’t deserialize Markdown strings in the Content Editor so we don’t need markdown-it
.
This MR removes markdown-it
from the Content Editor bundle by changing the import statement of prosemirror-markdown
to only target the to_markdown
module. prosemirror-markdown
does not support tree-shaking.
Screenshots (strongly suggested)
This MR does not introduce user-facing changes.
With markdown-it | Without markdown-it | Size Reduction |
---|---|---|
![]() |
![]() |
-33kb (from 45kb to 12kb) |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because this MR does not introduce user-facing changes.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team