Skip to content

Prevent loading of cohorts data if not necessary

What does this MR do?

This turns the tabs in the admin users list into regular links so that we can load the data separately.

Screen_Shot_2021-04-21_at_9.56.21_PM

So instead of just a simply showing / hiding a div, these tabs now trigger a full page reload.

I think this is acceptable since this is just in the admin panel. The alternative is to make it do an AJAX request.

We're doing this because the cohorts query times out on GitLab.com: https://log.gprd.gitlab.net/app/discover#/doc/7092c4e2-4eb5-46f2-8305-a7da2edad090/pubsub-rails-inf-gprd-004818?id=fdzK83gBa0YDjQVg1B8Z

This prevents admins from loading the users list.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #328519 (closed)

Edited by Heinrich Lee Yu

Merge request reports