Skip to content

Add 'view History' Button for Secret-Detection

Jannik Lehmann requested to merge jnnkl-secretDetection-view-history-button into master

What does this MR do?

This MR solves #326463 (closed).

It adds an "View History" Link to the Secret Detection Status on the Security & Compliance Configuration page, when Secret Detection is enabled.

The link leads to the blame page for the ci file of the project.

How to reproduce

  1. Enable the sec_secret_detection_ui_enable feature flag, to see the secret Detection row on the configuration Page.
echo "Feature.enable(:sec_secret_detection_ui_enable)" | rails c
  1. Go to a project where Secret Detection is enabled

  2. Go to "Security & Compliance" -> Configuration

  3. You should see the new link in the status column

Screenshots (strongly suggested)

Screenshot_2021-04-21_at_15.00.20

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jannik Lehmann

Merge request reports