Remove Legacy Group-Level DORA metrics API [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
The LEGACY Group-Level DORA metrics API has never been enabled due to the performance concern. We should remove this feature as it's currently blocking performance optimization around DeploymentFinder
. There are NO risks to result in breaking change.
FYI, We already released new API in a few months back. See #323713 (closed).
This also fixes the wrongly implemented EE::DeploymentsFinder
. It extends the capability of searching deployments of a given group. The functionality itself should exist in FOSS-level, as the group-deployment indirect relationship does exist in FOSS too.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team