Skip to content

Move alerts in pipeline_editor_app to its own component

What does this MR do?

There is currently a lot of repeated code in the root vue app for the pipeline editor section. There is a lot of code we could move to it's own component and let it handle what message to display. This is also fairly important in regard to additions from other team looking to use the root app component to display messages (example: !58664 (merged)).

There should be no visual change from this MR.

Screenshots (strongly suggested)

No visual changes. Here are 2 videos showing that everything still works for alerts:

Screen_Recording_2021-04-21_at_12.20.13_PM

Screen_Recording_2021-04-21_at_12.49.18_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #328453 (closed)

Edited by Frédéric Caplette

Merge request reports