Convert admin/users view - update specs for feature flag rollout
What does this MR do?
This MR updates the feature specs for admin/users to be compatible with the changes introduced in migrating the table over to Vue &4961 (closed).
Testing & Setup
Requires an GitLab Ultimate license to use all of the admin/users features.
- Disable the feature flag
echo "Feature.disable(:vue_admin_users)" | rails c - View the HAML table at
[GDK_HOST]/admin/users - Enable the feature flag
echo "Feature.enable(:vue_admin_users)" | rails c - View the Vue table at
[GDK_HOST]/admin/users - Checkout default branch and repeat 1-4
Screenshots (strongly suggested)
Admin/user table
No visual change in HAML
| Before | After |
|---|---|
 |
 |
No visual change in Vue
| Before | After |
|---|---|
 |
 |
Unblock modal text
| HAML | Vue before | Vue after |
|---|---|---|
 |
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because there is no user facing change, and the modal update is behind a feature flag.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #326714 (closed)
Edited by Jiaan Louw