Fix paginator of Environment Serializer
What does this MR do?
Previously, we shipped an MR to optimize the Environment Serializer. In that MR, we added bunch of preloads to fix many N+1 problems, but there was a bug that pagination doesn't work correctly, which results in preloading for not only environments in the page, but also environments in the other pages.
This MR fixes the outstanding issue by processing paginator.paginate before batch_load runs.
Related #234055 (closed)
Screenshots (strongly suggested)
Grouped environments in the environment index page
List of environments in the grouped environment index page
We can see that preloading happens on the paginated environments.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team