Skip to content

Draft: Safely rename services table to integrations

Alex Kalderimis requested to merge ajk-201856-rename-services-table into master

What does this MR do?

See: #201856 (closed)

This renames the services table using the techniques explored in !54354 (merged)

Current status:

  • we need to deal with discovery of correct nullability state on columns
  • we need to update triggers (after this MR)

The best avenue here is to get !54354 (merged) merged first, and use the process it defines.

Migration output

== 20210420104220 RenameServicesTable: migrating ==============================
-- rename_table(:services, :integrations)
   -> 0.0145s
-- execute("CREATE VIEW services AS SELECT * FROM integrations")
   -> 0.0017s
== 20210420104220 RenameServicesTable: migrated (0.0207s) =====================

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis

Merge request reports